build: smaller container image #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
This PR uses multi-stage builds to reduce the container image size.
The container build file now copies all installed (and possibly compiled) dependencies to the final layer without keeping the build tools.
Not included in the final image are
Uncompressed size difference:
4.37GBvs3.79GB. A reduction of 600MB that dont have to be stored and transfered over the network anymore.Tests
Ich created a file based diff after each image layer and compared the changed files. All changed files that are needed are still copied over to the final image.
I stated the image build with and without the
USE_CUDA_DOCKER. The resulting image started with no problem